Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(packages): set npm/yarn/pnpm versions #570

Merged
merged 5 commits into from
Oct 23, 2024
Merged

chore(packages): set npm/yarn/pnpm versions #570

merged 5 commits into from
Oct 23, 2024

Conversation

enzonotario
Copy link
Collaborator

It sets the engine versions for all packages, to be able to install it in environments like StackBlitz:

image

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Oct 20, 2024 •
edited
Loading

Open in Stackblitz

brisa-adapter-vercel

bun add https://pkg.pr.new/brisa-build/brisa/brisa-adapter-vercel@570

brisa

bun add https://pkg.pr.new/brisa-build/brisa@570

brisa-pandacss

bun add https://pkg.pr.new/brisa-build/brisa/brisa-pandacss@570

brisa-tailwindcss

bun add https://pkg.pr.new/brisa-build/brisa/brisa-tailwindcss@570

create-brisa

bun add https://pkg.pr.new/brisa-build/brisa/create-brisa@570

www

bun add https://pkg.pr.new/brisa-build/brisa/www@570

commit: 95e7805

@enzonotario
Copy link
Collaborator Author

@aralroca previously I've added this changes only for brisa package, but then I noticed you changed these lines in the PR #562 (https://github.com/brisa-build/brisa/pull/562/files#diff-fa31e6b7191dd6fb715074c8b331c912df26fd6cca2c4dc9510a5742ac2faca7R144),

Was it intentional? I'm trying to add it again, this time for all packages, to be able to run it in StackBlitz.

However, so far I can't get it working with preview packages:

https://stackblitz.com/edit/stackblitz-starters-pq3bzs?file=package.json

@enzonotario enzonotario marked this pull request as draft October 20, 2024 23:44
@aralroca
Copy link
Collaborator

@enzonotario the problems comes on this script to update Bun version:

brisa/scripts/upgrade-bun.ts

Line 34 in 5b35d86

npm: 'please-use-bun',

You probably need to change it here, otherwise is updating the packages after running bun run upgrade (what this commit did it).

@enzonotario enzonotario marked this pull request as ready for review October 23, 2024 00:47
@enzonotario
Copy link
Collaborator Author

Nice! Now I understand. It's fixed now, and I've ran upgrade-bun. Thanks!

aralroca
aralroca approved these changes Oct 23, 2024
View reviewed changes
Copy link
Collaborator

@aralroca aralroca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @enzonotario

@aralroca aralroca merged commit a532f3d into canary Oct 23, 2024
5 of 8 checks passed
@aralroca aralroca deleted the feature/packages-engines branch October 23, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aralroca aralroca aralroca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@enzonotario @aralroca